Wireshark-bugs: [Wireshark-bugs] [Bug 1794] New: OSPF dissector does not decode TLVs in a Grace

Date: Fri, 24 Aug 2007 18:39:59 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1794

           Summary: OSPF dissector does not decode TLVs in a Grace LSA
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: todd.martin@xxxxxxx


Build Information:
Version 0.99.7-tjm-trunk-1 (SVN Rev 22533)

Compiled with GTK+ 2.10.12, with GLib 2.12.12, with WinPcap (version unknown),
with libz 1.2.3, with libpcre 6.4, with Net-SNMP 5.4, with ADNS, with Lua 5.1,
with GnuTLS 1.6.1, with Gcrypt 1.2.3, with MIT Kerberos, with PortAudio
PortAudio V19-devel, with AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 3.1
(packet.dll version 3, 1, 0, 27), based on libpcap version 0.9[.x], without
AirPcap.

Built using Microsoft Visual C++ 8.0 build 50727

--
The OSPF dissector does not decode grace-LSA TLVs.  The message "Unknown LSA
Type 3" is shown when it gets to the TLVs as shown here:

Open Shortest Path First
    OSPF Header
    LS Update Packet
        Number of LSAs: 1
        LS Type: Opaque LSA, Link-local scope
            LS Age: 0 seconds
            Options: 0x40 (O)
            Link-State Advertisement Type: Opaque LSA, Link-local scope (9)
            Link State ID Opaque Type: grace-LSA (3)
            Link State ID Opaque ID: 0
            Advertising Router: 192.0.0.2 (192.0.0.2)
            LS Sequence Number: 0x80000000
            LS Checksum: d41d
            Length: 44
            Unknown LSA Type 3


With this patch, the OSPF packet is decoded like this:

Open Shortest Path First
    OSPF Header
    LS Update Packet
        Number of LSAs: 1
        LS Type: Opaque LSA, Link-local scope
            LS Age: 0 seconds
            Do Not Age: False
            Options: 0x40 (O)
            Link-State Advertisement Type: Opaque LSA, Link-local scope (9)
            Link State ID Opaque Type: grace-LSA (3)
            Link State ID Opaque ID: 0
            Advertising Router: 192.0.0.2 (192.0.0.2)
            LS Sequence Number: 0x80000000
            LS Checksum: 0xd41d
            Length: 44
            Grace Period: 40 seconds
            Restart Reason: Unknown (0)
            Restart IP: 192.85.1.4 (192.85.1.4)


A capture file is attached that shows OSPF PDUs that use the grace-LSA.  Use
this diplay filter to find the relevant frames: (ospf.lsid_opaque_type == 3).

The patch also addresses the following issue in the OSPF dissector:
- Fix a checksum that was printed in hex, but did not prepend "0x"


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.