Wireshark-bugs: [Wireshark-bugs] [Bug 1522] New: Update to WLCCP Packet Decode

Date: Thu, 5 Apr 2007 15:25:25 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1522

           Summary: Update to WLCCP Packet Decode
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: spamknoll@xxxxxxxxxxxxx


Build Information:
Version 0.99.5

Copyright 1998-2007 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.10.6, with GLib 2.12.4, with libpcap 0.9.4, with libz
1.2.3, without libpcre, without Net-SNMP, without ADNS, without Lua, without
GnuTLS, without Gcrypt, without Kerberos, without PortAudio, without AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.18.2-34-default, with libpcap version 0.9.4.

Built using gcc 4.1.2 20061115 (prerelease) (SUSE Linux).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.

--

The attached diff for packet-wlccp.c has some extra decode details for the
Message Types and SubTypes. Someone may want to fix the way I formatted the
Info column to make it look nicer.

I tested the build and decode using the 0.99.5 release.
-------------------------------------------------


--- packet-wlccp.c.svn  2007-04-05 11:09:55.000000000 -0400
+++ packet-wlccp.c      2007-04-05 11:01:29.000000000 -0400
@@ -3,8 +3,9 @@
  *
  * Copyright 2005, Joerg Mayer (see AUTHORS file)
  * Copyright 2006, Stephen Fisher <stephentfisher@xxxxxxxxx>
+ * Copyright 2007, Kevin A. Noll <kevin.noll@xxxxxxxxxxxxx>
  *
- * $Id$
+ * $Id: packet-wlccp.c 20077 2006-12-09 02:25:23Z sfisher $
  *
  * Wireshark - Network traffic analyzer
  * By Gerald Combs <gerald@xxxxxxxxxxxxx>
@@ -78,6 +79,7 @@
        { 0, NULL                        }
 };

+
 static const value_string wlccp_subtype_vs[] = {
        { 0, "Request" },
        { 1, "Reply"   },
@@ -86,6 +88,21 @@
        { 0, NULL      }
 };

+static const value_string wlccp_msg_type_vs[] = {
+       { 0x1, "nmAck"                          },
+       { 0xb, "cmAAA"                          },
+       { 0xc, "cmPathInit"                     },
+       { 0xf, "cmWIDS"                         },
+       { 0x10, "nmConfigRequest"               },
+       { 0x11, "nmConfigReply"                 },
+       { 0x20, "nmApRegistration"              },
+       { 0x22, "nmScmKeepActive"               },
+       { 0x30, "nmClientEventReport"           },
+       { 0x31, "nmAllClientRefreshRequest"     },
+
+};
+
+
 static const value_string wlccp_node_type_vs[] = {
        { 0, "None"                         },
        { 1, "Access Point (AP)"            },
@@ -187,7 +204,12 @@

        if (check_col(pinfo->cinfo, COL_INFO)) {
                if(tvb_get_guint8(tvb, 0) == 0xC1) { /* Get the version number
*/
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "Message subtype:
%s",
+
+                       col_add_fstr(pinfo->cinfo, COL_INFO, "Message Type:
%-27s",
+                                    val_to_str(((tvb_get_guint8(tvb,
6)<<2)>>2) & 63,
+                                               wlccp_msg_type_vs, "Unknown"));
+
+                       col_append_fstr(pinfo->cinfo, COL_INFO, "              
Message subtype: %s",
                                     val_to_str((tvb_get_guint8(tvb, 6)>>6) &
3,
                                                wlccp_subtype_vs, "Unknown"));
                } else {
@@ -411,7 +433,7 @@

                { &hf_wlccp_base_message_type,
                  { "Base message type", "wlccp.base_message_type",
-                   FT_UINT8, BASE_HEX_DEC, NULL,
+                   FT_UINT8, BASE_HEX_DEC, VALS(wlccp_msg_type_vs),
                    MT_BASE_MSG_TYPE, "Base message type", HFILL }
                },


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.