Wireshark-bugs: [Wireshark-bugs] [Bug 1413] New: SVN version detection doesn't work if svn is no

Date: Sat, 3 Mar 2007 10:27:49 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1413

           Summary: SVN version detection doesn't work if svn is not found
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: ulf.lamping@xxxxxx


Build Information:
Version 0.99.6

Copyright 1998-2007 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.10.6, with GLib 2.12.6, with WinPcap (version unknown),
with libz 1.2.3, with libpcre 6.4, with Net-SNMP 5.4, with ADNS, with Lua 5.1,
with GnuTLS 1.6.1, with Gcrypt 1.2.3, with MIT Kerberos, with PortAudio
PortAudio V19-devel, with AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0
(packet.dll version 4.0.0.755), based on libpcap version 0.9.5, with AirPcap
2.0.0 build 708.

Built using Microsoft Visual C++ 8.0 build 50727
--
As you can see in the "build information" above, my private Wireshark builds
show SVN 0.99.6 without any mention of SVN - although it's an SVN build!

Critical lines from the build process:

Version configuration file version.conf not found.  Using defaults.
This is a build from SVN (or a SVN snapshot).
Can't exec "svn": No such file or directory at make-version.pl line 113,
<ENTRIES> line 1.
Use of uninitialized value in pattern match (m//) at make-version.pl line 114,
<ENTRIES> line 1.
Use of uninitialized value in pattern match (m//) at make-version.pl line 117,
<ENTRIES> line 1.
SVN version tag will be computed.
svnversion.h has been updated.

The svnversion.h only contains a single comment line afterwards: 
/* #define SVNVERSION "" */

However, if svn is not found, the version string should be at least something
like:

Wireshark 0.99.6 (SVN unknown)

instead of the string of the next 0.99.6 release that I get.

I have installed subversion (command line version), but it's not in the path -
that's certainly the cause of this bug, but a secondary problem here. Missing
svn should NOT result in a buggy version string under ANY circumstance.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.