Wireshark-bugs: [Wireshark-bugs] [Bug 1332] Diameter Address format AVPs don't decode properly

Date: Tue, 30 Jan 2007 23:11:38 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1332





------- Comment #11 from martin.mathieson@xxxxxxxxxxxx  2007-01-30 23:11 GMT -------
I think your message had the wrong AVP length.  It had 2 bytes of padding, but
your length field said 16 instead of 14.  There are 8 bytes of header, 6 bytes
of AVP data.

>From rfc 3588:

"Each AVP of type OctetString MUST be padded to align on a 32-bit
   boundary, while other AVP types align naturally.  A number of zero-
   valued bytes are added to the end of the AVP Data field till a word
   boundary is reached.  The length of the padding is not reflected in
   the AVP Length field."

Also:

"AVP Length
      The AVP Length field is three octets, and indicates the number of
      octets in this AVP including the AVP Code, AVP Length, AVP Flags,
      Vendor-ID field (if present) and the AVP data.  If a message is
      received with an invalid attribute length, the message SHOULD be
      rejected."

These make it clear that the length shouldn't be rounded up, but should
actually be 14.  Tomorrow I'll add a couple of malformed expert items to show
cases where the AVP length is wrong.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.