http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1058
------- Comment #2 from jharvell@xxxxxxxxxx 2006-09-08 04:39 GMT -------
I won't be able to try with the patch until next week. So I wouldn't wait if
you want to release this.
>From looking at the diff it looks like you detect a hex input string and then
convert it to the format you were expecting in this field before the patch. So
by looking at it, I am able to infer what the original expected format is.
It seems like before the patch, the user was expected to enter a single
character for each 8 bits of the key. But since only about 96 characters of
the ASCII character set are printable, this means there are about 160 different
8-bit values that could not be entered before the patch.
It doesn't make sense to me that the user was previously expected to generate
8-bit characters in the text box used for input. I would expected an "ASCII"
representation to be a base64 (Mime) representation so it could be input using
printable characters.
So is it possible the expected input is base64 and your patch accepts a
hexadecimal representation but does not convert it to the expected base64
input?
Maybe if you clearly explain the original input format that would help me to
understand if your patch should work.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.