Ethereal-users: Re: [Ethereal-users] bug in editcap start time and end time? -A -B

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "George P Nychis" <gnychis@xxxxxxx>
Date: Thu, 16 Mar 2006 11:29:24 -0500 (EST)
Ahhh you're right about -DDEBUG, i put the flag in when trying to solve the -A -B problem.

Thanks :)


> On 3/16/06, George P Nychis <gnychis@xxxxxxx> wrote:
>> I think you also left some sort of debugging in: gnychis@monster
>> ~/school/15744/project/logs $ editcap -A '2006-03-02 02:12:00' -B
>> '2006-03-02 02:12:30' scen1-comcast_to_ini-comcast.log test-start0.lo 
>> Optind = 5, argc = 7
> This is because for some reason you have -DDEBUG in your CFLAGS
> 
>> ... don't forget to clear up the format stuff in the output too... i
>> would submit the changes but i don't know how to use subversion yet :\
> 
> Done, When I'm back home I'll checkin
> 
>>> can you:
>>> 
>>> $ touch text2pcap.c $ make text2pcap
>>> 
>>> and see if you get any warnings?
>>> 
>>> Thanks
>>> 
>>> 
>>> 
>>> On 3/16/06, George P Nychis <gnychis@xxxxxxx> wrote:
>>>> By the way, i just realized this when compiling editcap: monster 
>>>> ethereal-0.10.14-SVN-17642 # make editcap /usr/bin/perl 
>>>> ./make-version.pl . Version configuration file version.conf not
>>>> found. Using defaults. This is not a SVN build. svnversion.h has
>>>> been updated. if gcc -DHAVE_CONFIG_H -I. -I. -I.  -I. -I./wiretap
>>>> -I/usr/local/include -DDEBUG -ggdb -DINET6
>>>> -D_U_="__attribute__((unused))" -Wall -Wpointer-arith -W  -g -O2
>>>> -I/usr/local/include -pthread -I/usr/include/gtk-2.0
>>>> -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
>>>> -I/usr/include/cairo -I/usr/include/pango-1.0 
>>>> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -MT editcap.o
>>>> -MD -MP -MF ".deps/editcap.Tpo" -c -o editcap.o editcap.c; \ then mv
>>>> -f ".deps/editcap.Tpo" ".deps/editcap.Po"; else rm -f
>>>> ".deps/editcap.Tpo"; exit 1; fi editcap.c:86: warning: this decimal
>>>> constant is unsigned only in ISO C90 editcap.c: In function `main':
>>>> editcap.c:415: warning: implicit declaration of function `strptime'
>>>> 
>>>> 
>>>> 
>>>>> It sounds preety odd to me.... why should strptime be yielding
>>>>> two diferent timezones for two different calls...
>>>>> 
>>>>> Even more odd is that on my mac the attached script  yields two 
>>>>> different TZs but editcap works!
>>>>> 
>>>>> I'm attaching you a test script (a modification of the last one),
>>>>> if it fails it is a plattform problem, you might want to open a
>>>>> bug to the distributuion you are using (I'm opening one to apple,
>>>>> this is at least a documentation bug) In the meanwhile I'll look
>>>>> for a workarround of this issue.
>>>>> 
>>>>> An interesting test would be to check how the windows version
>>>>> (which uses "our own" strptime) works
>>>>> 
>>>>> On 3/16/06, George P Nychis <gnychis@xxxxxxx> wrote:
>>>>>> Sorry for the spam, but i'm trying to help solve this
>>>>>> problem...
>>>>>> 
>>>>>> I debugged editcap.c in gdb and found that it computers
>>>>>> starttime and stoptime to the following: 1: starttime =
>>>>>> 1141283520 3: stoptime
>>>>>>>>> 1141282020
>>>>>> 
>>>>>> therefore, your "if (starttime > stoptime)" is true ... so its 
>>>>>> computing starttime and stoptime incorrectly
>>>>>> 
>>>>>> timecode for starttime was: 2: timecode = {tm_sec = 0, tm_min =
>>>>>> 12, tm_hour = 2, tm_mday = 2, tm_mon = 2,tm_year = 106, tm_wday
>>>>>> = 4, tm_yday = 60, tm_isdst = 0, tm_gmtoff = -18000,tm_zone =
>>>>>> 0x804d230 "EST"}
>>>>>> 
>>>>>> timecode for stoptime was: 4: timecode = {tm_sec = 0, tm_min =
>>>>>> 47, tm_hour = 2, tm_mday = 2, tm_mon = 2,tm_year = 106, tm_wday
>>>>>> = 4, tm_yday = 60, tm_isdst = 1, tm_gmtoff = -1209507840,tm_zone
>>>>>> = 0x0}
>>>>>> 
>>>>>> For some reason stoptime does not pick up a timezone which
>>>>>> could make the difference... i really am not sure how the times
>>>>>> are formed from the format, but i'll keep digging
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>>> On another note, if you want to try and kill two birds with
>>>>>>> one build... the output if editcap says the format should be:
>>>>>>> (format as YYYY-MM-DD hh-mm-ss)
>>>>>>> 
>>>>>>> however, i believe that it should be:
>>>>>>> 
>>>>>>> (format as YYYY-MM-DD hh:mm:ss)
>>>>>>> 
>>>>>>> because: gnychis@monster ~/school/15744/project/logs $
>>>>>>> editcap -A '2006-03-02 02:12:00' -B '2006-03-02 02:47:00' 
>>>>>>> scen1-comcast_to_ini-comcast.log test-start0.log editcap:
>>>>>>> start time is after the stop time gnychis@monster 
>>>>>>> ~/school/15744/project/logs $ editcap -A '2006-03-02
>>>>>>> 02-12-00' -B '2006-03-02 02-47-00'
>>>>>>> scen1-comcast_to_ini-comcast.log test-start0.log editcap:
>>>>>>> "2006-03-02 02-12-00" isn't a valid time format
>>>>>>> 
>>>>>>> 
>>>>>>> I don't know if this has anything to do with the other bug...
>>>>>>>  but, yeah just letting you know :)
>>>>>>> 
>>>>>>>> patience... it's cooking: http://buildbot.ethereal.com
>>>>>>>> 
>>>>>>>> 
>>>>>>>> On 3/15/06, George P Nychis <gnychis@xxxxxxx> wrote:
>>>>>>>>> sorry but how can i get that version, the highest i see
>>>>>>>>> is 17632 here: 
>>>>>>>>> http://www.ethereal.com/distribution/buildbot-builds/sour
>>>>>>>>> ce/
>>>>>>>>> 
>>>>>>>>>> I changed the type on which I stored the time in
>>>>>>>>>> editcap, that's in revision 17638 can you try that.
>>>>>>>>>> 
>>>>>>>>>> Still wondering what could had happened because the
>>>>>>>>>> time fits in 31 bits (log(1141285620)/log(2) < 31) and
>>>>>>>>>> 1141285620
>>>>>>>>>>> 1141283520.
>>>>>>>>>> 
>>>>>>>>>> L
>>>>>>>>>> 
>>>>>>>>>> On 3/15/06, George P Nychis <gnychis@xxxxxxx> wrote:
>>>>>>>>>>> gnychis@monster ~/school/15744/project/logs $ 
>>>>>>>>>>> ./test_time.sh 2006-03-02 02:12:00 -- 1141283520 
>>>>>>>>>>> 2006-03-02 02:47:00 -- 1141285620
>>>>>>>>>>> 
>>>>>>>>>>>> On 3/15/06, George P Nychis <gnychis@xxxxxxx>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>> gnychis@monster ~/school/15744/project/logs $
>>>>>>>>>>>>> editcap -A '2006-03-02 02:12:00' -B '2006-03-02
>>>>>>>>>>>>> 02:47:00' scen1-comcast_to_ini-comcast.log
>>>>>>>>>>>>> test-start0.log editcap: start time is after the
>>>>>>>>>>>>> stop time
>>>>>>>>>>>>> 
>>>>>>>>>>>>> My start time doesn't seem to be after the stop 
>>>>>>>>>>>>> time...
>>>>>>>>>>>>> 
>>>>>>>>>>>> That's odd...
>>>>>>>>>>>> 
>>>>>>>>>>>> can you run the attached script and give me the
>>>>>>>>>>>> output.
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> -- This information is top security. When you have
>>>>>>>>>>>> read it, destroy yourself. -- Marshall McLuhan
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> -- This information is top security. When you have read
>>>>>>>>>> it, destroy yourself. -- Marshall McLuhan 
>>>>>>>>>> _______________________________________________ 
>>>>>>>>>> Ethereal-users mailing list Ethereal-users@xxxxxxxxxxxx
>>>>>>>>>>  
>>>>>>>>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> --
>>>>>>>>> 
>>>>>>>>> _______________________________________________ 
>>>>>>>>> Ethereal-users mailing list Ethereal-users@xxxxxxxxxxxx 
>>>>>>>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>>> -- This information is top security. When you have read it,
>>>>>>>>  destroy yourself. -- Marshall McLuhan 
>>>>>>>> _______________________________________________
>>>>>>>> Ethereal-users mailing list Ethereal-users@xxxxxxxxxxxx 
>>>>>>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> 
>>>>>>> _______________________________________________
>>>>>>> Ethereal-users mailing list Ethereal-users@xxxxxxxxxxxx 
>>>>>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> 
>>>>>> _______________________________________________ Ethereal-users 
>>>>>> mailing list Ethereal-users@xxxxxxxxxxxx 
>>>>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>>>>> 
>>>>> 
>>>>> 
>>>>> -- This information is top security. When you have read it,
>>>>> destroy yourself. -- Marshall McLuhan 
>>>>> _______________________________________________ Ethereal-users 
>>>>> mailing list Ethereal-users@xxxxxxxxxxxx 
>>>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> 
>>>> _______________________________________________ Ethereal-users
>>>> mailing list Ethereal-users@xxxxxxxxxxxx 
>>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>>> 
>>> 
>>> 
>>> -- This information is top security. When you have read it, destroy 
>>> yourself. -- Marshall McLuhan 
>>> _______________________________________________ Ethereal-users
>>> mailing list Ethereal-users@xxxxxxxxxxxx 
>>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>>> 
>>> 
>> 
>> 
>> --
>> 
>> _______________________________________________ Ethereal-users mailing
>> list Ethereal-users@xxxxxxxxxxxx 
>> http://www.ethereal.com/mailman/listinfo/ethereal-users
>> 
> 
> 
> -- This information is top security. When you have read it, destroy
> yourself. -- Marshall McLuhan 
> _______________________________________________ Ethereal-users mailing
> list Ethereal-users@xxxxxxxxxxxx 
> http://www.ethereal.com/mailman/listinfo/ethereal-users
> 
> 


--