Hello Martin,
Martin Mathieson schrieb:
> Hi,
>
> This patch adds a 3 more auth parameters, and now parses the auth
> parameters in an Authentication-Info header.
>
> Regards,
> Martin
>
Two remarks/questions :
- The authentication-info header has a slightly different syntax as the
authenticate and authorization headers. It doesn't contain a field for
the authentication scheme at the beginning.
We should have an own routine for dissecting the authentication-info
header.
- There is no "auts" parameter in RFC 3261. Is it defined in another
SIP-Extension?
Regards,
Lars
> ------------------------------------------------------------------------
>
> Index: epan/dissectors/packet-sip.c
> ===================================================================
> --- epan/dissectors/packet-sip.c (revision 18189)
> +++ epan/dissectors/packet-sip.c (working copy)
> @@ -102,6 +102,9 @@
> static gint hf_sip_auth_uri = -1;
> static gint hf_sip_auth_domain = -1;
> static gint hf_sip_auth_stale = -1;
> +static gint hf_sip_auth_auts = -1;
> +static gint hf_sip_auth_rspauth = -1;
> +static gint hf_sip_auth_nextnonce = -1;
>
> /* Initialize the subtree pointers */
> static gint ett_sip = -1;
> @@ -428,6 +431,9 @@
> {"uri", &hf_sip_auth_uri},
> {"domain", &hf_sip_auth_domain},
> {"stale", &hf_sip_auth_stale},
> + {"auts", &hf_sip_auth_auts},
> + {"rspauth", &hf_sip_auth_rspauth},
> + {"nextnonce", &hf_sip_auth_nextnonce},
> };
>
> /*
> @@ -1792,6 +1798,7 @@
> case POS_WWW_AUTHENTICATE:
> case POS_PROXY_AUTHENTICATE:
> case POS_PROXY_AUTHORIZATION:
> + case POS_AUTHENTICATION_INFO:
> /* Add tree using whole text of line */
> if (hdr_tree) {
> proto_item *ti;
> @@ -2950,6 +2957,21 @@
> { "Stale Flag", "sip.auth.stale",
> FT_STRING, BASE_NONE, NULL, 0x0,
> "SIP Authentication Stale Flag", HFILL}
> + },
> + { &hf_sip_auth_auts,
> + { "Authentication Token", "sip.auth.auts",
> + FT_STRING, BASE_NONE, NULL, 0x0,
> + "SIP Authentication Token", HFILL}
> + },
> + { &hf_sip_auth_rspauth,
> + { "Response auth", "sip.auth.rspauth",
> + FT_STRING, BASE_NONE, NULL, 0x0,
> + "SIP Response auth", HFILL}
> + },
> + { &hf_sip_auth_nextnonce,
> + { "Next Nonce", "sip.auth.nextnonce",
> + FT_STRING, BASE_NONE, NULL, 0x0,
> + "SIP Next Nonce", HFILL}
> }};
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev