On 5/11/06, Ulf Lamping <ulf.lamping@xxxxxx> wrote:
ronnie sahlberg wrote:
> ACK.
>
> A feature to link hf fields to URLs would be very very useful and
> should not be limited to only OIDs.
>
>
> It would be nice with a generic api where one could link arbitrary
> hf_fields and/or values to arbitrary URLs.
>
> Would something similar to the PROTO_ITEM_SET_GENERATED macro be a
> better solution here?
> PROTO_ITEM_SET_URL ?
Yes, sounds good (and better than the FI_URI I've mentioned before).
We could also extend it with having a flat database file that is used
by proto_tree_add_...() that does the same thing. So that we dont
have to add a PROTO_ITEM_SET_URL() a thousand times for items that are
added from multiple codepaths.
So that
smb2.impersonation_level http://wiki.ethereal.com/SMB2/ImpersonationLevel
could be used to tell ethereal to make ALL items created for this
field to always be linked to this url without a need to specify it
explicitely in the code.
(some fields are referenced many times from the code)
This could also replace the "link to protocol page" code that is
another explicitely coded special case of external links.
It would be nice if there would be an indication in the dissect pane
to show that the particular item is linked to an external resource.
A link icon to the left of the field name in the dissect pane? If
there is only one such external link then clicking on it would open a
browser and go straight to that link. If there are multiple links
associated to the field then it would send you to the "primary" link
where which one is primary is selected by some mechanism.
Right clicking on the link icon would bring up a popup menu that only
contains the list of external links.
The normal popup menu would be as today and not contain any links (no
additional cluttering to the existing popup)