Tomas,
Definitely a better location for these functions.
Graeme
_____
From: Kukosa, Tomas [mailto:tomas.kukosa@xxxxxxxxxxx]
Sent: 01 May 2006 13:05
To: graeme@xxxxxxxxxxx; Ethereal development
Subject: RE: [Ethereal-dev] OID Field Information
Hi,
I would prefer to put OID related functions into e.g. oid_resolv.[ch]
instead of packet-ber.[ch].
I guess ber_get_oid_url() could be ranamed to get_oid_url() and located in
oid_resolv.[ch] as it is not BER related.
Regards,
Tomas
_____
Od: ethereal-dev-bounces@xxxxxxxxxxxx za uživatele Graeme Lunt
Odesláno: po 1.5.2006 12:34
Komu: 'Ethereal development'
Předmět: [Ethereal-dev] OID Field Information
Hi,
I have developed a patch so that if the user chooses "Field Information" (a
new context menu item) on a field type of FT_OID, a web page will be brought
up with their preferred reference page. (e.g.
http://www.alvestrand.no/objectid/2.5.18.5.html)
I just wanted to check that this is an appropriate way to go about it before
I check it in.
Specifically:
a) Is it architecturally correct to reference a dissector (packet-ber) from
the gtk\ portion of the tree?
b) Would a "link" style (like FT_FRAMENUM) be better than extending the
context menu?
There is a diff attached for the gtk/ files (packet-ber.[ch] patch not
included).
Comments?
Graeme
<<attachment: winmail.dat>>