I submitted a new packet-media.c.patch for bug #439, which incorporates
the changes Jaap requested below. See
http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=439 for the patch.
Also, I included an alternate patch to print.c.patch which would
essentially accomplish the same thing. I prefer the
packet-media.c.patch, but others may have a different opinion.
- Chris
-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] On Behalf Of Jaap Keuter
Sent: Thursday, April 20, 2006 11:13 AM
To: Ethereal development
Subject: RE: [Ethereal-dev] Old Bugs with no responce
Hi,
Thanks for the patch, but what if bytes<0? You still create your
subtree, which you subsequently leave empty.
I also don't like to return half way, when bytes<0, but that's just my
taste.
Thanx,
Jaap
On Thu, 20 Apr 2006, Maynard, Chris wrote:
> Regarding bugs, was the one I proposed for 439 not acceptable? I
> realize there are other ways to solve the problem, so if my proposed
> solution is not desirable, then I won't be offended, but it seems like
a
> simple enough bug to fix and close.
> http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=439
> - Chris
-----------------------------------------
This email may contain confidential and privileged material for the
sole use of the intended recipient(s). Any review, use, retention,
distribution or disclosure by others is strictly prohibited. If you
are not the intended recipient (or authorized to receive for the
recipient), please contact the sender by reply email and delete all
copies of this message. Also, email is susceptible to data
corruption, interception, tampering, unauthorized amendment and
viruses. We only send and receive emails on the basis that we are
not liable for any such corruption, interception, tampering,
amendment or viruses or any consequence thereof.