["Anders Broman" <a.broman@xxxxxxxxx>]

Hi,
1). Fixed in SVN revision 17757 (Wrong length used).
2). I've changed it.
3). I wrote the code to dissect Ethertype 0x8881(ETHERTYPE_CDMA2000_A10_UBS)
dissection (with Guy's help), so I knew were to look :)

Besides that the code:
  next_tvb = tvb_new_subset(tvb, offset, -1, -1);
  if (!dissector_try_port(gre_dissector_table, type, next_tvb, pinfo, tree))
    call_dissector(data_handle,next_tvb, pinfo, gre_tree);

Calls the next dissector so you need to find which dissectors registers in
the table and how, to figure out what to do:
packet-ppp.c:
void
proto_reg_handoff_ppp_raw_hdlc(void)
{
  dissector_handle_t ppp_raw_hdlc_handle;

  ppp_raw_hdlc_handle = create_dissector_handle(dissect_ppp_raw_hdlc,
proto_ppp);
  dissector_add("gre.proto", ETHERTYPE_CDMA2000_A10_UBS,
ppp_raw_hdlc_handle);
  dissector_add("gre.proto", ETHERTYPE_3GPP2, ppp_raw_hdlc_handle);
}

Hope this helps.
Brg
Anders


-----Ursprungligt meddelande-----
Från: Ravi Valmikam [mailto:rvalmikam@xxxxxxxxxxx] 
Skickat: den 28 mars 2006 21:16
Till: ethereal-dev@xxxxxxxxxxxx
Kopia: a.broman@xxxxxxxxx
Ämne: RE: [PATCH] Minor fix for 3GPP2 A11 Session Update and Sample Captures


 
Andres

I have downloaded the nightly image and noticed a couple of things in 3GPP2
GRE dissector.

1. The Flow Id is now showing up as 2 bytes. It should be only 1 byte. In
the attached capture, for example, flow Id should have been 0x00. It shows
up incorrectly as 0x007E.

2. The attribute display is a bit difficult to read. 

     > 1x SDB/HRPD DoS Indicator (Reserved)
          .000 0001 = Type: Short Data Indicator (0x01)
          Length: 0x02
          0... .... .... .... = Short Data Indicator(SDI): Reserved

     > 1x SDB/HRPD DoS Indicator (packet suitable for 1x SDB or HRPD DOS
transmission)
          .000 0001 = Type: Short Data Indicator (0x01)
          Length: 0x02
          1... .... .... .... = Short Data Indicator(SDI): packet suitable
for 1x SDB or HRPD DOS transmission

     > Flow Control Indicator (XOFF, INDEFINITE)
         Length: 0x02
         1... .... .... .... = Flow Control Indicator: XOFF
         .1.. .... .... .... = Duration Indicator: INDEFINITE:
   
   Unless expanded, they will look like
     > 1x SDB/HRPD DoS Indicator (Reserved)
     > 1x SDB/HRPD DoS Indicator (packet suitable for 1x SDB or HRPD DOS
transmission)
     > Flow Control Indicator (XOFF, INDEFINITE)

   This will make it really easy for me in everyday debugging in the lab.

Let me know if this is OK with you.

Also, can you spare a moment and let me know how you got the PPP dissection
working? I tried my best to figure out the code path but could not figure it
out :-)

Thanks
Ravi
       


Date: Mon, 27 Mar 2006 18:30:11 +0200
From: "Anders Broman" <a.broman@xxxxxxxxx>
Subject: SV: [Ethereal-dev] [PATCH] Minor fix for 3GPP2 A11 Session
	Update	andSample Captures
To: "'Ethereal development'" <ethereal-dev@xxxxxxxxxxxx>
Message-ID: <001f01c651bb$b7dc2530$6800a8c0@ditt7huk3o9fm5>
Content-Type: text/plain;	charset="iso-8859-1"

Checked in alongside some changes to the way the GRE information is
displayed and making the PPP dissector display the payload.
Brg
Anders

-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Ravi Valmikam
Skickat: den 27 mars 2006 02:29
Till: ethereal-dev@xxxxxxxxxxxx
Ämne: [Ethereal-dev] [PATCH] Minor fix for 3GPP2 A11 Session Update
andSample Captures

 
Hi

Attached file contains a minor fix for 3GPP2 A11 Session Update and a
set of capture files .cap and decoded .txt files.

Please apply the patch to the source tree at your convenience.

I will update the Wiki pages as soon as possible.

Thanks
Ravi