Ethereal-dev: Re: [Ethereal-dev] Armagetronad dissector update

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guillaume Chazarain <guichaz@xxxxxxxx>
Date: Mon, 27 Mar 2006 17:58:01 +0200
Jaap Keuter wrote:

+               guint16 *ptr, *end = (guint16*) &data[data_len];
+               for (ptr = (guint16*) data; ptr != end; ptr++) {

This will never end when data_len is odd.

guint16 data_len = tvb_get_ntohs(tvb, offset + 4) * 2;
This can't happen ;-)

Thanks.


--
Guillaume