Hi,
------------------------------------------------------------------------
r17639 | jake | 2006-03-15 22:22:11 +0100 (Wed, 15 Mar 2006) | 1 line
Changed paths:
M /trunk/epan/dissectors/packet-ncp2222.inc
Add missing preference storage.
------------------------------------------------------------------------
Index: packet-ncp2222.inc
===================================================================
--- packet-ncp2222.inc (revision 17638)
+++ packet-ncp2222.inc (working copy)
@@ -48,6 +48,7 @@
gboolean ncp_echo_err = TRUE;
gboolean ncp_echo_conn = TRUE;
gboolean ncp_echo_server = TRUE;
+gboolean ncp_echo_file = TRUE;
extern dissector_handle_t nds_data_handle;
typedef struct {
This commit created the required preference storage. Please update your
working copy.
Thanx,
Jaap
On Sun, 19 Mar 2006, Guy Harris wrote:
> CHarris@xxxxxxxxxxxxxxxxxxxx wrote:
> > Yea, I have the packet-ncp-int.h file in my \ethereal\epan\dissectors
> > directory.
>
> ...which declares ncp_echo_file, but doesn't define it. ("extern"
> declares, but doesn't define, a C variable.)
>
> I don't know why the other values, such as ncp_echo_err, don't show this
> problem. (I also don't know why that didn't show up in the buildbot
> buils; perhaps different versions of MSVC++ use different models, such
> as def/ref vs. common.)
>
> Unless those are used outside packet-ncp.c, they should probably just be
> made static to packet-ncp.c, and not declared in packet-ncp-int.h.
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>