Ethereal-dev: [Ethereal-dev] Re: rev 17485: /trunk/epan/: emem.c emem.h

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "ronnie sahlberg" <ronniesahlberg@xxxxxxxxx>
Date: Sat, 11 Mar 2006 06:15:34 +0000
didier,

can you test with latest SVN?

please remember to comment out guard pages and canaries.


i found one place where i forgot to repaint a node,  causing the tree
to become severely unbalanced when you add sequentially incrementing
(or decrementing) valuesm   such as packetnumbers etc.


LEGO,   can you also test?


i guess this is a pefect example of our previous discussion about the
only drawback with rb trees,    while very fast and efficient,   they
are not trivial to implement :-)




On 3/10/06, didier <dgautheron@xxxxxxxx> wrote:
> ronnie sahlberg wrote:
> > ok   can you test with  the latest SVN    there are two defines in
> > emem.c   you should remove    WANT_GUARD_PAGES   and
> > DEBUG_USE_CANARIES.
> >
> WANT_GUARD_PAGES undefined, in the noise.
> DEBUG_USE_CANARIES  undefined 3 mn.
>
> with
> WANT_GUARD_PAGES and DEBUG_USE_CANARIES defined 2mn 30
>
> with nfs using hash:
> 53 sec.
>
>
> Note:
> I've only updated emem.c
>
> Didier
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>