Ethereal-dev: Re: [Ethereal-dev] AVA - QBSS Patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Thomas Sillaber" <Thomas.Sillaber@xxxxxx>
Date: Wed, 11 Jan 2006 19:33:52 +0100 (MET)
Hola,

thanks for the feedback,

> On Wed, Jan 11, 2006 at 12:40:47AM +0100, Jaap Keuter wrote:
> > A few notes on your patch:
> > - Coding style is not anything like the original file.
> 
> The coding style is ok. This file is a mess as far as coding style is
> concerned anyway.
> 
> >   Different, sometimes inconsistent indentations.
> 
> Looks ok to me, I fix the indentation to the style I like whenever I
> touch some code in this file.
> 
> > - Where do you need the hidden fields for?
> 
> right. no new hidden fields please.

I want to create filter tag shows if the protocoll is present, to filter
like bootp.vendor.alcatel (find packets oncluding AVA). The only way I know
is to set a hidden boolean. If there is another way the please let me know.


The qbbs_version is to set the version. Why is this a problem?


TIA

Thomas

-- 
Telefonieren Sie schon oder sparen Sie noch?
NEU: GMX Phone_Flat http://www.gmx.net/de/go/telefonie