Ethereal-dev: [Ethereal-dev] [PATCH] BACnet packet-bacapp.c fix

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Steve Karg <skarg@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 05 Jan 2006 11:11:14 -0500
Hi Developers!

I fixed fBACnetPropertyValue in the BACnet packet-bacapp.c dissector where an optional decoding for Priority wasn't being optional. A valid packet with a confirmedEventNotification that did not have the optional priority made this bug evident by indicating Malformed Packet.

I generated test packets with BACnet VTS and verified the fix, and then fuzz tested this for awhile with my captures and saw no problems.

Attached is a patch.

Best Regards,

Steve Karg

Attachment: bacnet.patch.gz
Description: Binary data