Hi Anders,
This patch is different from the one you are refering to.
http://www.gossamer-threads.com/lists/ethereal/dev/40347
That one states:
- return (addVendor(atoi(code), id, name));
+ return (addVendor(atoi(id), code, name));
while Joost proposes:
- return (addVendor(atoi(code), id, name));
+ return (addVendor(id, atoi(code), name));
Which seems to fit
<vendor vendor-id="Merit" code="61" name="Merit Networks"/>
as mentioned by Guy in the thread.
Please contact Joost Yervante Damad <joost@xxxxxxxxxx>
for further details.
Thanx,
Jaap
On Sun, 25 Dec 2005, Anders Broman wrote:
> Hi,
> That patch is faulty as previously noted on this list.
> Brg
> Anders
>
> -----Ursprungligt meddelande-----
> Fr?n: ethereal-dev-bounces@xxxxxxxxxxxx
> [mailto:ethereal-dev-bounces@xxxxxxxxxxxx] F?r Jaap Keuter
> Skickat: den 25 december 2005 11:04
> Till: Ethereal Developer Mailinglist
> Kopia: Joost Yervante Damad
> ?mne: [Ethereal-dev] Ethereal fails to correctly add diameter vendors from
> the dictionary xml files [PATCH]
>
> Hi list,
>
> In the Debian bug database is an entry from Joost Yervante Damad
> <joost@xxxxxxxxxx>
> concerning the diameter dissector:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=316082
>
> I've ported the patch to revision 16893, so it's ready for inclusion. For
> further details refer to the Debian bug report or Joost.
>
> Thanx,
> Jaap
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>