checked in.
i still dont like messing with packet-frame.[ch] but the only other
option would be to add a
hashtable to track the dst_ref to frame numbers and that might be too
much work to be worth it for a protocol that can never be made to do
reliable reassembly anyway.
On 12/8/05, Stig Bjørlykke <stig@xxxxxxxxxxxxx> wrote:
> Hi.
>
> Any status on this patch?
>
>
> --
> Stig Bjørlykke
>
>
> On 2. des. 2005, at 20.12, Stig Bjørlykke wrote:
>
> > Hi.
> >
> > Did anyone have a look at my capture and my proposed patch to fix
> > reassembling of the COTP segments? I don't know if it's ok to
> > patch packet-frame to help packet-clnp like this, and I don't know
> > any other solution.
> >
> > Capture: http://www.ethereal.com/lists/ethereal-dev/200511/
> > msg00348.html
> > Patch: http://www.ethereal.com/lists/ethereal-dev/200511/msg00341.html
> >
> >
> > --
> > Stig Bjørlykke
> >
> >
> > On 29. nov. 2005, at 17.49, Stig Bjørlykke wrote:
> >
> >> Hi.
> >>
> >> Here is a sample capture which doesn't dissect correctly, look at
> >> frame 14 which should reassemble the COTP segments from frame 13
> >> and 14, and display a X.411 message. Applying the patch in my
> >> previous mail will fix this problem. Any comments on the patch?
> >>
> >> If the X.411 message doesn't dissect correctly after applying my
> >> patch try merging this capture with p772-transfer-success.pcap
> >> from http://wiki.ethereal.com/S4406, as I think it's a bug in the
> >> X.411 dissector somewhere (the message in this capture is a X.420,
> >> not a STANAG 4406).
> >>
> >> BTW: why doesn't the fragments of a COTP segment include a link to
> >> the reassembled frame? (like in frame 13 in this capture)
> >>
> >>
> >> --
> >> Stig Bjørlykke
> >>
> >> <x411-stig.pcap>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>