Ethereal-dev: Re: [Ethereal-dev] NULL for the blurb for a header field?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Gerald Combs <gerald@xxxxxxxxxxxx>
Date: Fri, 11 Nov 2005 14:20:00 -0600
Guy Harris wrote:
> gerald@xxxxxxxxxxxx wrote:
> 
>>User: gerald
>>Date: 2005/11/10 06:04 PM
>>
>>Log:
>> Don't use null values for blurbs in header fields.
>>
>>Directory: /trunk/epan/dissectors/
>>  Changes    Path              Action
>>  +8 -8      packet-p_mul.c    Modified
> 
> 
> Currently, a lot of dissectors have null strings for blurbs; should we
> allow a null pointer for the blurb, meaning "sorry, nobody's written a
> blurb for this field" (which is what a null string means), and add checks
> for a null blurb pointer?

gtk/main.c checks to see if an hfinfo's blurb is null or "", and if so
uses the "name" field instead.  We might want to do this in
proto_registrar_dump_fields() or force "blurb" to be valid in
proto_register_field_array().