On that first one, "Stop" does sound better. The function used in
gtk/progress_dlg.c:create_progress_dlg() seems to be changed so that it
always uses the cancel button, even though the comment of the function
describes a paremter for passing a string to be used on that button.
One the second note, yes, other places in the code use similar
constructions. That is why I didn't change the dialog handler itself, but
its user, so other users wouldn't be influenced. These other users must be
evaluated by themselves to see if such a partial load is possible/
applicable/desireable in that situation.
If the need arisses, we surely will see an entry on the WishList, as we
did for this one.
Thanx,
Jaap
On Thu, 10 Nov 2005, Guy Harris wrote:
> Ulf Lamping wrote:
>
> > I've done some extensions:
> > -Improve the corresponding comment on the implications why this is useful
> > -added a new simple_dialog text to explain what's really going on
> > (simply using the WTAP truncated packet message was a bit misleading)
>
> Given that it's really not cancelling the load - it doesn't undo all the
> stuff done as part of the load - should the button say "Stop" rather
> than "Cancel"?
>
> Also, do other places that read files, e.g. the file merge code, check
> for the stop button and stop the operation?
>