["Olivier Biot (Ethereal)" <ethereal@xxxxxxxxxxxxxxx>]

Hi folks,

This bug is related to calling proto_item_append_string() which does a 
progressive update of a FT_STRING or FT_STRINGZ field.

I have been looking at it for the past 6 hours, and have come to the 
conclusion that a header field can get "promoted" to FT_PROTOCOL (FTENUM = 
1), as can be seen from a private debug trace I generated with a patched 
proto.c and packet-wsp.c (see below).

Is it possible that the TRY_TO_FAKE_THIS_ITEM speed optimization is causing 
this?

If so, how can this be fixed? Do I have to manually set the visibility of 
all these incrementally updateable fields to "always visible", or is there 
another trick?

Best regards,

Olivier



COMMON ERROR MESSAGE:
BEGIN
** (tethereal.exe): WARNING **: Dissector bug, protocol WSP, in packet 
[[[pinfo->fd->num]]]: proto.c:1580: failed assertion "hfinfo->type == 
FT_STRING || hfinfo->type == FT_STRINGZ"
proto_item_append_string() - test: [! Error]: field "wsp" has type == 
FT_PROTOCOL}}
END

Occurs at the following packets (positions relative to my patched 
packet-wsp.c, hence a minimal context).

WSP: Packet 117 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 139 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 174 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 194 packet-wsp.c:4466: proto_item_append_string (ti, s); [in 
parameter_value_q()]
WSP: Packet 210 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 229 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 262 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 290 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 293 packet-wsp.c:4142: proto_item_append_string(ti, s); [1st in 
parameter()]
WSP: Packet 314 packet-wsp.c:4466: proto_item_append_string (ti, s); [in 
parameter_value_q()]
WSP: Packet 343 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 347 packet-wsp.c:4142: proto_item_append_string(ti, s); [1st in 
parameter()]
WSP: Packet 397 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 462 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 502 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 514 packet-wsp.c:5700: proto_item_append_string(ti, " (push 
facility)");
WSP: Packet 528 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 557 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 562 packet-wsp.c:4157: proto_item_append_string(ti, s); [2nd in 
parameter()]
WSP: Packet 585 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 627 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");
WSP: Packet 676 packet-wsp.c:5698: proto_item_append_string(ti, " (confirmed 
push facility)");


----- Original Message ----- 
From: <bugzilla-do-not-reply@xxxxxxxxxxxx>
To: <ethereal-bugs@xxxxxxxxxxxx>
Sent: Monday, July 25, 2005 6:08 PM
Subject: [Ethereal-bugs] [Bug 298] New: WSP: dissector assert on 
privatelyfuzzed capture


> http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=298
>
>           Summary: WSP: dissector assert on privately fuzzed capture
>           Product: Ethereal
>           Version: SVN
>          Platform: PC
>        OS/Version: Windows XP
>            Status: NEW
>          Severity: Normal
>          Priority: Medium
>         Component: Ethereal
>        AssignedTo: ethereal-bugs@xxxxxxxxxxxx
>        ReportedBy: ulf.lamping@xxxxxx
>
>
> Build information:
> Version 0.10.12.028 (SVN 20050724220114)
> --
>
> Ethereal raises a dissector assert when opening the attached privately 
> fuzzed
> WSP capture file.
>
> --
> Configure bugmail: 
> http://bugs.ethereal.com/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> _______________________________________________
> Ethereal-bugs mailing list
> Ethereal-bugs@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-bugs