Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] rev 15993: /trunk/epan/dissectors/: packet-osp

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sun, 25 Sep 2005 01:42:31 +0200
sahlberg@xxxxxxxxxxxx wrote:


User: sahlberg
Date: 2005/09/24 04:22 PM

Log:
remove an array from the stack,   remove some strcpy() and strcat() calls

Directory: /trunk/epan/dissectors/
 Changes    Path             Action
 +15 -16    packet-ospf.c    Modified




Hmmm, any idea what the expression:

&& (prefix_options_string[position-1] != '/')

in the if expressions are for?

I don't see any reason.
Beside the fact that it's buggy, as it will access prefix_options_string[-1] if the former options weren't set. 

Simply remove them?

Regards, ULFL