I've spent most of this week fixing bugs discovered by Buildbot. Most
of my Ethereal development time is spent this way, so much so that it's
gotten out of hand. We need more people fixing bugs and/or fewer bugs
checked in.
How can we make sure that changes are properly tested _before_ they're
checked in? I've been thinking of adding the following requirements for
any non-trivial change that modifies dissector behavior:
The code MUST be accompanied by a statement from the author,
submitter, or committer stating that the change has been fuzz tested.
The Buildbot environment MUST be able to test the code; i.e. captures
that exercise the code should be added to the capture menagerie if
they aren't already there.
Comments and suggestions are welcome. As it stands, the next release
will have to be postponed. I haven't been able to prep for it and my
calendar is booked solid for the next two weeks.
Buildbot wrote:
> Problems have been found with the following capture file(s):
>
> http://www.ethereal.com/distribution/buildbot-builds/randpkt/editcap.4331ae7a.pcap
>
>
> Error information:
> (no core file found)
>
>
> stderr follows:
>
> ** (process:44786): WARNING **: Dissector bug, protocol GSM_MAP, in packet 171: proto.c:1503: failed assertion "hfinfo->type == FT_STRING || hfinfo->type == FT_STRINGZ"
>
>
> Bug 470 posted.
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev