Ethereal-dev: Re: [Ethereal-dev] DCCP: new dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Gerald Combs <gerald@xxxxxxxxxxxx>
Date: Tue, 20 Sep 2005 15:19:50 -0500
Francesco Fondelli wrote:
> On 9/20/05, Gerald Combs <gerald@xxxxxxxxxxxx> wrote:
>>4, in dissect_options(), option_len defaults to 0.  Could this result in
>>an infinite loop later on?
> 
> 
> Hemm, I have been watching that loop for a while and I think is ok.
> option_len at each iteration is something > 2 or ==1 else [malformed]
> exit loop and return.

You're right.  I wasn't looking at the code closely enough.