Ethereal-dev: SV: [Ethereal-dev] Re: Patch to packet-dec-dnart.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Anders Broman" <a.broman@xxxxxxxxx>
Date: Tue, 6 Sep 2005 20:12:06 +0200
Hi,
There seems to be something wrong with the patch:
C:\ethereal>patch epan/dissectors/packet-dec-dnart.c decnet.patch
patching file epan/dissectors/packet-dec-dnart.c
patch: **** malformed patch at line 7: /* Flag bits */

Brg
Anders

-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Martin Hill
Skickat: den 4 september 2005 16:46
Till: ronniesahlberg@xxxxxxxxx; ethereal-dev@xxxxxxxxxxxx
Ämne: [Ethereal-dev] Re: Patch to packet-dec-dnart.c

Changed as requested. Also fixed some other bugs in control message 
decoding.

rgds
Martin Hill


>From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
>To: Ethereal development <ethereal-dev@xxxxxxxxxxxx>
>CC: martin_j_hill@xxxxxxxxxxx
>Subject: Re: Patch to packet-dec-dnart.c
>Date: Wed, 24 Aug 2005 03:39:56 -0400
>
>The patch does not apply to SVN,
>
>can you regenerate it and resend it.
>
>
>Looking at the dissector,   could you also remove that
>APPEND_BOOLEAN_FLAG thing and replace it with proper
>proto_tree_add_item()   and hf_fields of type FT_BOOLEAN
>
>It would make the dissector much better.
>
>
>
>On 8/21/05, Martin Hill <martin_j_hill@xxxxxxxxxxx> wrote:
> > An extremely useful addition, unfortunately it has a bug that prevents 
>it
> > from correctly decoding messages containing no padding. I also added 
>display
> >
> > of DECnet addresses in area.node format. Attached is a diff from the 
>latest
> >
> > trunk.
> >
> > rgds
> > Martin Hill
> >
> >
> >