Ethereal-dev: RE: SV: [Ethereal-dev] PRES and RTSE dissectors (and X.400dissectors) -> BER CHO

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Graeme Lunt" <graeme.lunt@xxxxxxxxx>
Date: Mon, 5 Sep 2005 23:05:17 +0200
> Hi,
> I have fixed the basic problems but it seems like there is a 
> problem with BER CHOISE now showing up in the FTAM traces - 
> could some one please help look into it?

Attached is a patch to solve the CHOICE problem for review. 

Problem was two-fold:
1) not passing original class/tag to sub-choice we had matched BER_CLASS_ANY
2) not handling a count==0 if we had matched BER_CLASS_ANY 

FTAM trace now looks good - but there are problems with the last finish
disconnect - but haven't looked into it. MMS trace also looks good at a
first glance but I don't really know what to expect.

The patch also includes a my constructed octet string fix again for review,
and a fix for bad naming in the STANAG 4406 dissector.


Graeme

Attachment: patch-choice.diff
Description: Binary data