Ethereal-dev: SV: [Ethereal-dev] Re: Patch for indefinite length for packet-ber.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Anders Broman" <a.broman@xxxxxxxxx>
Date: Sun, 28 Aug 2005 21:51:40 +0200
Hi,
I have checked in the b and c part of the patch for now.
Brg
Anders

-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Graeme Lunt
Skickat: den 26 augusti 2005 14:51
Till: tim@xxxxxxxxxxxxxxx; 'Ethereal development'
Ämne: RE: [Ethereal-dev] Re: Patch for indefinite length for packet-ber.c

Tim, Anders,

> Can you grab the latest svn, as I have been making a number of fixes
> over the last few weeks as different traces have been made
> available(thanks). The first bug is dealt with in a different way now
> but the second is valid.
> 
> I have attached my latest version with your fix done, can you 
> check that it still works with your nested indefinite length traces.

I've gotten the latest version out of svn and everything looks good with my
traces (my second fix had already been incorporated).


I attach a patch to packet-ber.c to fix:

a) dissect_ber_octet_string() to reassemble constructed OCTET STRINGs
b) dissect_ber_set() to report missing fields and handle untagged CHOICEs
c) dissect_ber_choice() to handle untagged CHOICEs (within the CHOICE)


Graeme