[Ulf Lamping <ulf.lamping@xxxxxx>]

ronnie sahlberg wrote:

> I just finished going through and checking all value_strings in
> dissectors and did find more than a handful ones that were not
> properly terminated with a {0,NULL} entry.
>
> These should all be fixed now.
>
>  
Yes, I remember that I've fixed some of these before, found by 
fuzz-testing. Seems to be a somewhat common mistake.

As these bugs are hard to find if they really occur, is there a way to 
automatically check for this termination?

> In GMS-A   there was a very peculiar value_string : gsm_dtap_elem_string
> that just looks very wrong.
>
> Could one of the telco people have a look at that one    or should we
> just wait until it is ASN2ETHified?
>  
IMHO it would be a good idea to fix it now, so it won't get lost.

Regards, ULFL