Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] rev 15515: /trunk/epan/dissectors/: packet-ext

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 23 Aug 2005 15:41:26 +0200
On Tue, Aug 23, 2005 at 08:34:21AM +0000, guy@xxxxxxxxxxxx wrote:
> Log:
>  Use "format_text()" and "tvb_format_text()" when displaying strings. 
>  (It's not necessary, or desirable, to use them when fetching strings.)

Nice :-)

>  When processing a VLAN TLV, check the length of the TLV, so we don't end
>  up running past the end of the TLV and getting a negative remaining
>  length.

This cannot happen because the main loop checks that at least 4 bytes for
the tlv are available - or did I misunderstand something?

>  Append to the protocol tree item for the TLV, and the Info
>  column, as we dissect the VLAN ID and VLAN name fields.

Well, I was too lazy for that, and since nobody requested it ;->

 Ciao
    Joerg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.