Ethereal-dev: [Ethereal-dev] Re: rev 15335: /trunk/epan/dissectors/: packet-tcp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Sat, 13 Aug 2005 03:33:06 -0400
On 8/13/05, guy@xxxxxxxxxxxx <guy@xxxxxxxxxxxx> wrote:
> User: guy
> Date: 2005/08/13 02:30 AM
> 
> Log:
>  Do the sequence number analysis *before* dissecting the payload, so we
>  don't have to worry about catching exceptions in the payload dissection
>  and doing the sequence number analysis - we weren't doing so in one
>  place.  That also puts the sequence number analysis *before* the "TCP
>  payload" entry for payload being reassembled into a later packet.
>  
>  XXX - should we do the tapping before dissecting the payload, too, so
>  that it gets done even if we throw an exception?


YES