[Albert Chin <ethereal-dev@xxxxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Aug 04, 2005 at 10:30:53PM +0200, Joerg Mayer wrote:
> On Thu, Aug 04, 2005 at 02:24:30PM -0500, Albert Chin wrote:
> > The attached patch fixes this.
> 
> Content-Description: Patch
> > --- epan/ftypes/ftype-tvbuff.c.orig	Tue Jul 26 14:26:02 2005
> > +++ epan/ftypes/ftype-tvbuff.c	Thu Aug  4 12:24:08 2005
> 
> > -#include <epan/gdebug.h>
> 
> > --- epan/dfilter/gencode.c.orig	Tue Jul 26 14:26:02 2005
> > +++ epan/dfilter/gencode.c	Thu Aug  4 12:24:08 2005
> 
> > -#include <epan/gdebug.h>
> 
> I don't think that this is the proper solution:  There is a reason
> why we use our own gdebug.h (at least that's what I hope).
> Just using the glib gdebug.h is not a solution. Maybe we shouldn't
> redefine gdebug but use a different name instead?

$ gtar zxf ethereal-0.10.12.tar.bz2
$ cd ethereal-0.10.12
$ find . -type f -exec grep g_debug {} \; -print
 * g_debug() always passes. */
#define _g_debug(format, args...) \
/* Always pass a empty-string argument to _g_debug() so that g_debug will always
 * have at least 2 arguments. If user passes 1 arg to g_debug() (i.e., only
 * a format string), _g_debug() will still work. */
#define g_debug(args...) \
        _g_debug(args, "")
g_debug(const char* format, ...)
./epan/gdebug.h

So, g_debug isn't used *anywhere*. So, why not delete it?

-- 
albert chin (china@xxxxxxxxxxxxxxxxxx)