[Gerald Combs <gerald@xxxxxxxxxxxx>]

Yuriy Sidelnikov wrote:
> Hi,
> I've found recently that presentation dissector doesn't work  now.
> I guess reason is in wrong using of tvb_ensure_bytes_exist function.
> SVN-14193 has added a lot of lines looks like :
> tvb_ensure_bytes_exist(tvb, offset, -1);
> As I can see from comment in the tvb_ensure_bytes_exist function:
>     /*
>      * -1 doesn't mean "until end of buffer", as that's pointless
>      * for this routine.  We must treat it as a Really Large Positive
>      * Number, so that we throw an exception; we throw
>      * ReportedBoundsError, as if it were past even the end of a
>      * reassembled packet, and past the end of even the data we
>      * didn't capture.
>      *
>      * We do the same with other negative lengths.
>      */
> So I don't think we can use -1 as argument for this function because -1
> will always throw exception.
> We need to use real length but sometimes it is not very easy.

I've backed out the changes.  The problems the tvb_ensure_bytes_exist()
calls were supposed to fix have been addressed in proto.c.  Could you
check revision 14298 or later to see if things are working correctly?