[Pilz Rene <rene.pilz@xxxxxx>]

Hi

The patch looks fine.  I would propose to apply it.

thanks

Rene

Miklos Szurdi wrote:

> Hi
>
>
> here is the patch for epan/dissectors/packet-gsm_a.c
> will someone please check if it is okay...
>
> thanks
>
> Miklos
>
> --- Pilz Rene <rene.pilz@xxxxxx> wrote:
>  
>
> > Hi
> >
> > Miklos Szurdi wrote:
> >
> >    
> >
> > > Hi
> > >
> > > I found that in PDP modify context request messages
> > >      
> > in
> >    
> >
> > > the Qos field the Maximum bit rate (both uplink and
> > > downlink) is a bit hard to read.
> > >
> > > According to the 3GPP 24008-x it is coded in 8bits:
> > >
> > > 00xx xxxx
> > > 1-63Kbits 1Kb steps
> > > decoded correctly in ethereal
> > >
> > > 01xx xxxx
> > > 64-576Kbits 8Kbits steps
> > > decoded almost correctly :
> > > (oct-0x40)*8 and this means it will say 0 when it
> > >      
> > is
> >    
> >
> > > actually 64Kbps and so on
> > >
> > > 1xxx xxxx
> > > 577-8640Kbits 64Kbits steps
> > > same problem as above
> > >
> > > Is this intentional?
> > > Or I should correct it?
> > >
> > >
> > >      
> > This is actually a bug. Please fix it. I will have
> > not earlier time than 
> > mid/end of the next week.
> >
> > Rene
> >
> >    
> >
> > > Miki
> > >
> > >
> > > __________________________________________________
> > > Do You Yahoo!?
> > > Tired of spam?  Yahoo! Mail has the best spam
> > >      
> > protection around 
> >    
> >
> > > http://mail.yahoo.com 
> > >
> > > _______________________________________________
> > > Ethereal-dev mailing list
> > > Ethereal-dev@xxxxxxxxxxxx
> > >      
> > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> >    
> >
> > >      
> > --
> > Dipl-Ing (FH) MSc. C.E Ren� Pilz
> > ftw. Telekommunications Research Center Vienna
> > http://www.ftw.at
> > Tech Gate Vienna, Donaucitystra�e 1, A-1220 Wien
> > Mobile: +43 664 8269871 Office: +43 1 5052830-13 
> > Fax: +43 1 5052830-99
> >
> > _______________________________________________
> > Ethereal-dev mailing list
> > Ethereal-dev@xxxxxxxxxxxx
> >
> >    
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>  
>
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around 
> http://mail.yahoo.com 
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>  


--
Dipl-Ing (FH) MSc. C.E Ren� Pilz
ftw. Telekommunications Research Center Vienna http://www.ftw.at
Tech Gate Vienna, Donaucitystra�e 1, A-1220 Wien
Mobile: +43 664 8269871 Office: +43 1 5052830-13  Fax: +43 1 5052830-99