Martin Mathieson schrieb:
I wanted to do a patch that was purely a cleanup, but some other things
sneaked in. I've tested it with all of the captures I have here, donations
gratefully received.
Mixed patch (cleanup and new features) are not a good idea. It is nearly unreadable.
Martin
This update includes:
- re-indenting/formatting the file as it was tricky to follow
- some code simplification and commenting (more to do)
- losing some unnecessary includes (not needed under linux at least...)
- show duplicate request and response fields in tree (previously hidden)
- improved duplicate response detection
- fix a couple of problems shown by fuzz testing
Still to do:
- I'd like to change the way the 'Display raw text for MGCP message' is
done, to make it more like SIP. All of the 'my_proto...' function pointer
stuff clutters the code and isn't done throughout anyway
- Make it not a plugin anymore
How about separating work for this. I do the reindentation and you redo the
patch, based on my reindentation. This should significantly decrease the size of
the patch.
I hope this won't be too much work for you.
If you agree, I will check in the reindentation of packet-mgcp.c.
Regards,
Lars