Ethereal-dev: [Ethereal-dev] Re: [Patch] Correction of VoIP Calls with ordered taps - H323 SIP

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Lars Roland <lars.roland@xxxxxxx>
Date: Thu, 14 Apr 2005 02:55:09 +0200
Alejandro Vaquero schrieb:

Hi All,
Find attached a patch to fix the H323 and SIP (not changes needed for MGCP) voip_calls for the new tap ordering. The patch also improve the dynamic SDP payload type dissection adding individual hash tables per SDP Media Description to the conversation. 

I've checked in the fix for the voip call analysis.
I haven't checked in the changes for the SDP dissector, because they contain at least one serious bug. In line 1059 of packet-sdp.c (with your your patch applied) key2 is used uninitialized. Besides this bug I have some doubts about the rest, too. IMO the block from line 1052 to 1068 is very ugly and I'm not sure if it works correctly. Some comments could help here. 
I have some additional questions about this patch.
Is it a bugfix or just an improvement? and if not, will this patch replace a huge hash table (>1000 entries) with some smaller tables? 

Regards,
Lars