Devin Heitmueller wrote:
Your code is derived from Eric Rescorla's ssldump code. His code very explictly has an advertising clause in the license, making it incompatible with the GPL. This means the Ethereal project cannot distribute the code. You might be able to contact him and see if you can get permission to relicense the code under the GPL (I remember at one point somebody on the mailing list said he asked him and said it was ok but you would need to approach him yourself).
Agreed, this needs to be sorted out before checking the patch in.
The bigger issue though is that Rescorla's code relies heavily on OpenSSL, which also includes an advertising clause making it incompatible with the GPL. The OpenSSL group will not relicense their code to make it GPL compatible, so this is a major showstopper.
Why? As we discussed many times on this list, the GPL is about *distribution*.
As long as we don't *distribute* OpenSSL code together with Ethereal (e.g. by
linking with OpenSSL libraries), there's no problem. This means, our binary
distributions unfortunately can *not* have "SSL decryption" functionality. But
anyone *can* build Ethereal with "SSL decryption" from the source distribution.
+Thomas
--
Thomas Anders (thomas.anders at blue-cable.de)