Checked in,
hope it compiles.
the code in the mgcp dissector still looks very ugly though.
That is what happens with dissectors living down in ./plugins
On Fri, 8 Apr 2005 13:08:27 +0200, "Anders Broman (AL/EAB)"
<anders.broman@xxxxxxxxxxxx> wrote:
> Hi,
> Looks ok to me and compile works, so could some one please check it in. I
> can't do it
> at the moment as I'm traveling.
> Best regards
> Anders
>
> -----Original Message-----
> From: ethereal-dev-bounces@xxxxxxxxxxxx
> [mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of ronnie sahlberg
> Sent: den 8 april 2005 12:36
> To: Ethereal development
> Subject: [Ethereal-dev] Re: MGCP update
>
>
> I hope someone will review this patch of yours.
> I dont compile with plugins myself so I cant do it.
> (the plugin dissectors are living in unmaintained land as far as i see
> it, but boy is the mgcp dissector ugly? would be very nice to
> refactor it to look nice and later convert it to become a normal
> dissector)
>
>
>
> On Thu, 7 Apr 2005 22:46:49 +0100, Martin Mathieson
> <martin.mathieson@xxxxxxxxxxxx> wrote:
> > Please consider instead this version, which also corrects the filter
> value
> > of mgcp.req.verb (to not include the full name as well as the code of the
> > verb).
> >
> > Thanks,
> > Martin
> >
> >
> > > Hi,
> > >
> > > Here are some more MGCP improvements:
> > >
> > > - added some missing return code value_strings
> > > - added a couple of missing param types
> > > - better handling of extension param types
> > > - can now filter for 'mgcp.params'
> > > - show response time as a generated field
> > > - some whitespace cleanup
> > >
> > > Regards,
> > > Martin
> >
> >
> >
> ----------------------------------------------------------------------------
> > ----
> >
> >
> > > _______________________________________________
> > > Ethereal-dev mailing list
> > > Ethereal-dev@xxxxxxxxxxxx
> > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> > >
> >
> >
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>