Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] rev 14009: /trunk/epan/dissectors/: packet-ncp

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <gilramir@xxxxxxxxx>
Date: Thu, 7 Apr 2005 15:52:04 -0500
On Thursday 07 April 2005 03:17, Greg Morris wrote:
> Well, the access to the fvalue_ functions was added several years back by
> Gilbert to allow the ncp2222.py Python script to display column data from
> the current request packet. In the Python script each NCP request decode
> has the ability to pass an info_str. This string is evaluated in
> packet-ncp2222.inc and then echoed to the info column data. Perhaps we
> should consult Gilbert regarding those changes. 
>  pkt.Request(8), [
>  ], info_str=(Path, "Release Lock on: %s", "/%s"))

Right, the information column data is built up from the info_str, which looks 
at data that was put into the ncp_tree. It will be difficult to change 
because we're using the ptvc_* routines to semi-automatically add data to the 
ncp_tree... most of the NCP dissector is table-driven.  We don't ever have 
the interesting data in hand. By "interesting data" I mean the data that goes 
into the info column string. That's why we consult the ncp_tree, via the 
finfo's.

--gilbert