[ronnie sahlberg <ronniesahlberg@xxxxxxxxx>]

checked in


On Wed, 30 Mar 2005 09:32:57 +0100, Tim <tim@xxxxxxxxxxxxxxx> wrote:
> 
> 
> Small fix to packet-ber.c to clear this crash, but there still might be
> something wrong with the gsmmap checkiemi definition.
> 
> 
> Index: packet-ber.c
> ===================================================================
> --- packet-ber.c (revision 13681)
> +++ packet-ber.c (working copy)
> @@ -452,7 +452,8 @@
>    if( (class!=BER_CLASS_UNI) 
>  
> ||((tag<BER_UNI_TAG_NumericString)&&(tag!=BER_UNI_TAG_OCTETSTRING)&&(tag
> !=BER_UNI_TAG_UTF8String)) ){
>            proto_tree_add_text(tree, tvb, offset-2, 2, "BER
> Error: OctetString expected but Class:%d PC:%d Tag:%d was unexpected",
> class, pc, tag);
> -    *out_tvb=NULL;
> +          if (out_tvb)
> +     *out_tvb=NULL;
>     return end_offset;
>    }
>   } else {
> 
> 
> 
> Im sure Anders has this in hand though.
> 
> Tim
> 
> -----Original Message-----
> From: ethereal-dev-bounces@xxxxxxxxxxxx
> [mailto:ethereal-dev-bounces@xxxxxxxxxxxx] On Behalf Of Wan Hing Wah
> Sent: 30 March 2005 02:51
> To: ethereal-dev@xxxxxxxxxxxx
> Subject: [Ethereal-dev] bug report : ethereal 0.10.10 crash for gsm
> mapmessage dump
> 
> 
> (resent to ethereal-dev from ethereal-user since it is the approiorate 
> place for bug report)
> 
> Hi,
>      The attached dump file which is captured in ethereal 0.10.8  cause
> ethereal 0.10.10 to crash. No problem for opening it in 0.10.8.
> 
> backtrace :
> 
> #0  0x40297e71 in dissect_ber_octet_string ()
>     from /usr/lib/ethereal/libethereal.so.0
> (gdb) bt
> #0  0x40297e71 in dissect_ber_octet_string ()
>     from /usr/lib/ethereal/libethereal.so.0
> #1  0x4041b1fe in proto_reg_handoff_gsm_a ()
>     from /usr/lib/ethereal/libethereal.so.0
> #2  0x4041b288 in proto_reg_handoff_gsm_a ()
>     from /usr/lib/ethereal/libethereal.so.0
> #3  0x4042b4db in proto_reg_handoff_gsm_a ()
>     from /usr/lib/ethereal/libethereal.so.0
> #4  0x40298a2d in dissect_ber_sequence ()
>     from /usr/lib/ethereal/libethereal.so.0
> #5  0x4042caea in proto_reg_handoff_gsm_a ()
>     from /usr/lib/ethereal/libethereal.so.0
> #6  0x4042cb3a in proto_reg_handoff_gsm_a ()
>     from /usr/lib/ethereal/libethereal.so.0
> #7  0x40298d90 in dissect_ber_choice () from
> /usr/lib/ethereal/libethereal.so.0
> #8  0x4042cf70 in proto_reg_handoff_gsm_a ()
>     from /usr/lib/ethereal/libethereal.so.0
> #9  0x4042d06e in proto_reg_handoff_gsm_a ()
>     from /usr/lib/ethereal/libethereal.so.0
> #10 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #11 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #12 0x401dc045 in dissector_try_port () from
> /usr/lib/ethereal/libethereal.so.0
> #13 0x406c7ca2 in tcap_check_tag () from
> /usr/lib/ethereal/libethereal.so.0
> ---Type <return> to continue, or q <return> to quit---
> #14 0x406c9358 in tcap_check_tag () from
> /usr/lib/ethereal/libethereal.so.0
> #15 0x406c967c in tcap_check_tag () from
> /usr/lib/ethereal/libethereal.so.0
> #16 0x406ca915 in tcap_check_tag () from
> /usr/lib/ethereal/libethereal.so.0
> #17 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #18 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #19 0x401dc045 in dissector_try_port () from
> /usr/lib/ethereal/libethereal.so.0
> #20 0x4062b664 in proto_reg_handoff_sap ()
>     from /usr/lib/ethereal/libethereal.so.0
> #21 0x4062bf58 in proto_reg_handoff_sap ()
>     from /usr/lib/ethereal/libethereal.so.0
> #22 0x4062c1c6 in proto_reg_handoff_sap ()
>     from /usr/lib/ethereal/libethereal.so.0
> #23 0x4062cd88 in proto_reg_handoff_sap ()
>     from /usr/lib/ethereal/libethereal.so.0
> #24 0x4062e0fc in proto_reg_handoff_sap ()
>     from /usr/lib/ethereal/libethereal.so.0
> #25 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #26 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #27 0x401dc045 in dissector_try_port () from
> /usr/lib/ethereal/libethereal.so.0
> #28 0x40542a2d in mtp3_addr_to_str_buf ()
>     from /usr/lib/ethereal/libethereal.so.0
> #29 0x40542cef in mtp3_addr_to_str_buf ()
>     from /usr/lib/ethereal/libethereal.so.0
> ---Type <return> to continue, or q <return> to quit---
> #30 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #31 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #32 0x401dd493 in call_dissector () from
> /usr/lib/ethereal/libethereal.so.0
> #33 0x40523c5a in proto_reg_handoff_m2tp ()
>     from /usr/lib/ethereal/libethereal.so.0
> #34 0x40524b68 in proto_reg_handoff_m2tp ()
>     from /usr/lib/ethereal/libethereal.so.0
> #35 0x40524e8d in proto_reg_handoff_m2tp ()
>     from /usr/lib/ethereal/libethereal.so.0
> #36 0x40524f37 in proto_reg_handoff_m2tp ()
>     from /usr/lib/ethereal/libethereal.so.0
> #37 0x40525007 in proto_reg_handoff_m2tp ()
>     from /usr/lib/ethereal/libethereal.so.0
> #38 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #39 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #40 0x401dc045 in dissector_try_port () from
> /usr/lib/ethereal/libethereal.so.0
> #41 0x4063d443 in proto_register_scsi ()
>     from /usr/lib/ethereal/libethereal.so.0
> #42 0x4063d969 in proto_register_scsi ()
>     from /usr/lib/ethereal/libethereal.so.0
> #43 0x4063efe1 in proto_register_scsi ()
>     from /usr/lib/ethereal/libethereal.so.0
> #44 0x4063f40d in proto_register_scsi ()
> ---Type <return> to continue, or q <return> to quit---
>     from /usr/lib/ethereal/libethereal.so.0
> #45 0x4063fd0b in proto_register_scsi ()
>     from /usr/lib/ethereal/libethereal.so.0
> #46 0x4063fe69 in proto_register_scsi ()
>     from /usr/lib/ethereal/libethereal.so.0
> #47 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #48 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #49 0x401dc045 in dissector_try_port () from
> /usr/lib/ethereal/libethereal.so.0
> #50 0x404c3a3e in dissect_ip_tcp_options ()
>     from /usr/lib/ethereal/libethereal.so.0
> #51 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #52 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #53 0x401dc045 in dissector_try_port () from
> /usr/lib/ethereal/libethereal.so.0
> #54 0x403ab23f in ethertype () from /usr/lib/ethereal/libethereal.so.0
> #55 0x403a8309 in capture_eth () from /usr/lib/ethereal/libethereal.so.0
> #56 0x403a84f0 in add_ethernet_trailer ()
>     from /usr/lib/ethereal/libethereal.so.0
> #57 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #58 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #59 0x401dc045 in dissector_try_port () from
> /usr/lib/ethereal/libethereal.so.0
> #60 0x403d3411 in proto_reg_handoff_fr ()
>     from /usr/lib/ethereal/libethereal.so.0
> #61 0x401db703 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> ---Type <return> to continue, or q <return> to quit---
> #62 0x401dbb98 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #63 0x401dd493 in call_dissector () from
> /usr/lib/ethereal/libethereal.so.0
> #64 0x401db5a0 in dissect_packet () from
> /usr/lib/ethereal/libethereal.so.0
> #65 0x401d842c in epan_dissect_run () from
> /usr/lib/ethereal/libethereal.so.0
> #66 0x0806af5f in cf_set_rfcode ()
> #67 0x0806b357 in cf_set_rfcode ()
> #68 0x0806a83e in cf_read ()
> #69 0x08083750 in main ()
> 
> 
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>