Ethereal-dev: Re: [Ethereal-dev] Banish ALL kinds of g_assert from epan (dissector) code?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Tue, 22 Mar 2005 20:01:07 -0800
Gerald Combs wrote:

Ulf Lamping wrote:



It's not that I don't want to fix bugs (I'm doing that continuously for
the time being), but IMHO it's more important to have a non crashing
Ethereal than to fix the bugs.

Single packets marked as [Dissector Bug] will be much more user friendly
than a crash because of a g_assert().

Any objections against this?



Sounds good to me.
The buildbot dissection tests should probably check for "Dissector bug" messages in the standard error (I'm assuming that g_warning() writes its output to the standard error; if not, it'd have to check for that in the standard output), so that if a dissector bug is found, it'll get reported.