Ethereal-dev: Re: [Ethereal-dev] DATAFILE_DIR should be set in Makefile.am, not configure.in

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Graeme Hewson <ghewson@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 06 Feb 2005 20:33:17 +0000
Albert Chin wrote:

From autoconf.info:

     In order to support these features, it is essential that `datadir'
  remains being defined as `${prefix}/share' to depend upon the current
  value of `prefix'.

     A corollary is that you should not use these variables except in
  Makefiles.  For instance, instead of trying to evaluate `datadir' in
  `configure' and hard-coding it in Makefiles using e.g.,
  `AC_DEFINE_UNQUOTED(DATADIR, "$datadir")', you should add
  `-DDATADIR="$(datadir)"' to your `CPPFLAGS'.

Patch attached against 0.10.9.
See my earlier message... the global data directory is now defined as /usr/local/share instead of /usr/local/share/ethereal. The code removed from configure.in defined datafiledir=$datadir/ethereal, not $datadir, so I don't think the comment in autoconf.info applies, and I think the code can simply be put back into configure.in as it was.