Ethereal-dev: [Ethereal-dev] Patch for packet-gsm_sms.c : Correction for TP-Validity-Period ex

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Victor Stratan <hidralisk@xxxxxxxxx>
Date: Sat, 15 Jan 2005 07:47:26 -0800 (PST)
Hello,

Fix 1:
Offset not incremented for relative type

Fix 2:
Semioctets not reversed for HHMMSS relative type

=====
Live long and prosper,
  Vik


		
__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - Easier than ever with enhanced search. Learn more.
http://info.mail.yahoo.com/mail_250
--- ethereal-0.10.8-SVN-13043/epan/dissectors/packet-gsm_sms.c	2005-01-15 02:25:35.000000000 +0200
+++ ethereal-0.10.8-SVN-new/epan/dissectors/packet-gsm_sms.c	2005-01-15 15:37:03.688067967 +0200
@@ -920,6 +920,7 @@
 		    "%s :  Validity Period Format: relative",
 		    bigbuf);
 
+		offset++;
 		/* go around again */
 		vp_form = 2;
 		break;
@@ -957,12 +958,12 @@
 		proto_tree_add_text(subtree,
 		    tvb, offset, 3,
 		    "Hour %d%d, Minutes %d%d, Seconds %d%d",
-		    (oct & 0xf0) >> 4,
 		    oct & 0x0f,
-		    (oct2 & 0xf0) >> 4,
+		    (oct & 0xf0) >> 4,
 		    oct2 & 0x0f,
-		    (oct3 & 0xf0) >> 4,
-		    oct3 & 0x0f);
+		    (oct2 & 0xf0) >> 4,
+		    oct3 & 0x0f,
+		    (oct3 & 0xf0) >> 4);
 
 		done = TRUE;
 		break;