Ethereal-dev: Re: [Ethereal-dev] Double free corruption

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date: Sun, 9 Jan 2005 07:04:10 +0100
> > What about runtime "errors" is a g_message fine in those cases or
> > should mate just be quiet?
> 
> "Errors" in what sense?  If the error is something the user needs to
> correct, use report_failure().  If it's not something the user needs to
> correct, does it need to be reported at all?

I checked mate's code for warnings printed during runtime, there are
only three left.

One whenever mate truncates a string because it's bigger than the
buffers it uses to store them. I realy do not thing this is going to
happen often, the huge buffers are larger than anything that can be
extracted from a normal frame (I've never seen a single frame larger
than 4K in my life). I do not thing this is ever going to be printed.,
I'll get rid of it.

Another one whenever atempting to remove an already removed string.
(which would be a consecuence of some bug). I think I should keep it
there as a warning. If someone ever sees it he/she might report it.

The last one is whenever one of the declared transport protocols is
missing. Thinking about it makes no sense reporting it. I might want
to do something like "Proto=sip; Transport=udp/tcp/ip;" to be able to
handle both sip over udp and sip over tcp with the same pdu type; It
would be noisy to keep it as a warning, obnoxious if it pops up
windows whenever it happens.

Thanks