Ethereal-dev: Re: [Ethereal-dev] RTP analysis patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 17 Oct 2004 15:14:53 -0700
Alejandro Vaquero wrote:

Find attached a patch to RTP analysis to avoid RTP packets with Version != 2 (a crash if using Version 0 occurred).

For some reason, the patches to packet-rtp.c and packet-rtp.h attempted to replace the entire file (line-ending issues?), and didn't apply. Fortunately, the version being patched is the current top-of-tree SVN version, so I could just delete the old lines from the patch and get rid of the leading "+"s and replace the source file with the result.

The patch to rtp_analysis.c didn't have that problem.

I've checked in the change.

Is it necessary to have "rtp_packet()" ignore packets with an RTP version that's not 2? It looks as if the RTP dissector doesn't call "tap_queue_packet()" on packets other than RTP version 2 packets, so "rtp_packet()" should never be called with a non-RTPv2 packet.