Ethereal-dev: Re: [Ethereal-dev] [Potential-patch] Support for latest libxml2 onwin32 platform

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Thu, 14 Oct 2004 19:23:07 +0200
From: Olivier Jacques




Using Diameter dissector with XML definition files on WIN32 platforms
doesn't work.
It has been reported by several people:
http://www.ethereal.com/lists/ethereal-dev/200403/msg00748.html
http://www.ethereal.com/lists/ethereal-users/200405/msg00153.html
http://www.ethereal.com/lists/ethereal-users/200307/msg00247.html


The patch attached fixes this issue by removing XML validation against
DTD. Please check it in.

It could look radical, but XML validation is not really necessary in our
case.
I also tested the fact that having syntax errors in the dictionary files
are still properly detected.
Tested OK on Debian woody and win32 systems.

For WIN32 system, you have to put the libxml2.dll from
http://www.zlatkovic.com/libxml.en.html#binaries in the path where
Ethereal can find it. I putted mine in c:\windows\system32\

Thanks to Anders who was kind enough to do some initial testing.
Olivier.


Great!
I'd however provide a patch with a conditional compilation of the DTD validation code. This way, we may still provide it the day it's required. 

Best regards,
Olivier