[Tomas Kukosa <tomas.kukosa@xxxxxxxxxxx>]

The patch is attached.


ronnie sahlberg wrote:
> can you change the patch to also not create a body such as
>    return  dissect_.....
>
> the _PDU()s are void and shouldnt return an integer
>
>
>
> On Mon, 13 Sep 2004 09:24:24 +0200, Tomas Kukosa
> <tomas.kukosa@xxxxxxxxxxx> wrote:
>
> > Sorry for that mistake. The patch is attached.
> >
> >
> >
> >
> > ronnie sahlberg wrote:
> >
> >
> > > ---------- Forwarded message ----------
> > > From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
> > > Date: Mon, 13 Sep 2004 16:51:15 +1000
> > > Subject: Re: [Ethereal-dev] ASN2ETH - new version
> > > To: Ethereal development <ethereal-dev@xxxxxxxxxxxx>
> > >
> > > the changes to the compiler has been checked in.
> > >
> > > i converted all of 509ce to use .PDU as well but did not check it in.
> > >
> > > Can you change the compiler so that it generates a slightly different
> > > signature for the _PDU() functions?
> > >
> > > register_ber_oid_dissector() expects a dissector_t *  argument
> > > which are all static void functions
> > > but .PDU generates static int functions.
> > >
> > > Can you change the compiler so that the _PDU() functions are static
> > > void instead of static int ?
> > >
> > >
> > >
> > >
> > > On Mon, 13 Sep 2004 06:41:48 +0200, Tomas Kukosa
> > > <tomas.kukosa@xxxxxxxxxxx> wrote:
> > >
> > >
> > > > Hello,
> > > >  the attached patch to the ASN2ETH compiler contains following changes:
> > > > - dot '.' can be used in the protocol name
> > > > - if the single output is used comments are not generated into all files but only into
> > > > single output file
> > > > - new commad line option "-O dir" for output directory
> > > > - new commad line option "-k" to keep all partial files if single ouput is used
> > > > - new directive PDU to generate PDU dissector routine
> > > >  (see attached example conformation file)
> > > >
> > > > Please, check in.
> > > >
> > > >  Regards,
> > > >    Tomas
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > Ethereal-dev mailing list
> > > > Ethereal-dev@xxxxxxxxxxxx
> > > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> > --
> > _________________________________________________
> >
> > ANF DATA              ANF DATA spol. s r. o.
> > a SIEMENS Company     M-palác, Heršpická 5
> >                      639 00 Brno
> >                      Czech Republic
> > Tomáš Kukosa          Tel.: +420 - 5 4310 6822
> > PSE ECT AES 6         Fax: +420 - 5 4324 8780
> > Room: 8.24            mailto:tomas.kukosa@xxxxxxxxxxx
> > _________________________________________________
> >
> >
> >
> > _______________________________________________
> > Ethereal-dev mailing list
> > Ethereal-dev@xxxxxxxxxxxx
> > http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev

--
_________________________________________________

ANF DATA              ANF DATA spol. s r. o.
a SIEMENS Company     M-palác, Heršpická 5
                      639 00 Brno
                      Czech Republic
Tomáš Kukosa          Tel.: +420 - 5 4310 6822
PSE ECT AES 6         Fax: +420 - 5 4324 8780
Room: 8.24            mailto:tomas.kukosa@xxxxxxxxxxx
_________________________________________________

Attachment: asn2eth.py.diff.gz
Description: GNU Zip compressed data