Ethereal-dev: [Ethereal-dev] Re: TCAP and GSM: if no display filter is set, Protocol and Info

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Jeff Morriss <jeff.morriss@xxxxxxxxxxx>
Date: Mon, 30 Aug 2004 17:53:43 -0400
Hi list,

Could this patch be reviewed (and hopefully checked in)?

Thanks,
-Jeff

Jeff Morriss wrote:


Jeff Morriss wrote:

If I load a capture with GSM MAP messages in it but don't use a 
display filter, the Protocol column says the messages are only TCAP 
and the Info: column just says "UDT" (from SCCP).
If, however, I add a display filter (any filter'll do, as would a 
color filter), the Protocol column says "GSM MAP" and the Info: column 
is populated with both TCAP and GSM information.
Looks like the "if (tree)" in "packet-tcap.c" needs to be taken out 
(or possibly done somewhere else--though I'm not sure where).
The same probably should be done to "packet-gsm_a.c", 
"packet-gsm_map.c", and "packet-gsm_sms.c".

The attached patch takes out most of the if(tree)'s (I couldn't find any place better to put them).