Ethereal-dev: Re: [Ethereal-dev] assertion failed in both ethereal and tethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Gisle Vanem" <giva@xxxxxxxxx>
Date: Sat, 28 Aug 2004 14:50:31 +0200
"Andrew Hood" <ajhood@xxxxxxxxx> wrote:

> So is the correct answer to check tcp_analyze_seq before calling 
> verify_tcp_window_scaling? That certainly fixes the crash.
> 
> Index: epan/dissectors/packet-tcp.c
> ===================================================================
> --- epan/dissectors/packet-tcp.c        (revision 11842)
> +++ epan/dissectors/packet-tcp.c        (working copy)
> @@ -2893,7 +2893,8 @@
>      * then we should just forget about the windowscaling completely.
>      */
>     if(!pinfo->fd->flags.visited){
> -    if((tcph->th_flags & (TH_SYN|TH_ACK))==(TH_SYN|TH_ACK)) {
> +    if(tcp_analyze_seq &&
> +       ((tcph->th_flags & (TH_SYN|TH_ACK))==(TH_SYN|TH_ACK))) {
>         verify_tcp_window_scaling(pinfo);
>       }
>     }

Great, I had the same problem, but was in no possition to fix it myself.
Your patch fixed it.

--gv