Ethereal-dev: Re: [Ethereal-dev] Patch submission

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Wed, 21 Jul 2004 12:48:57 +0200
From: Ulf Lamping

| Olivier Biot schrieb am 21.07.04 11:21:15:
|
| > I'd suggest using "svn diff -u [changed_files] > svn.diff" for
| > generating a patch. You can then review the diff and send it as an
| > attachment to your mail to ethereal-dev (as was the case with
CVS).
|
| Do we want to avoid getting whitespace changes? Or is this already
| done with this svn call?

I don't recommend using whitespace compression for diffs, as that way
you won't see any edits in C strings or readability fixes etc. However
I suggest to always review a diff (that's what I do anyway).

Best regards,

Olivier