Ethereal-dev: Re: [Ethereal-dev] Two further issues in 0.10.5

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Mon, 12 Jul 2004 21:16:37 +0200
Stuart MacDonald wrote:

Bug #11: Start capture dialog sometimes not centered.
Severity: Low
Effect: User annoyance, workaround available
Steps to Reproduce:
- start Ethereal
- ctrl-k to bring up the Start Capture dialog
- notice that occassionally the dialogue is partially off screen
- notice that when starting the capture, the Stats dialog correctly
 places itself in relative terms to the Start dialog, which is also
 partially off screen
Notes:
Once you've moved it around, further capture dialogs locate themselves
appropriately (remember where they should be).
Also note that this doesn't always happen, just once in a while.
However the dialogs do seem to move around the screen a lot.

Well, that's not a bug, but intentional. A new dialog window will be opened at the current mouse position, not at the middle of the screen (like before). This might result in a partially hidden/shown dialog.

This will reduce "mouse travelling" on large screens a lot.

The only exceptions (as far as I can remember) are the about dialog and splash screen, which are intended to be in the middle of the screen.

Bug #12: Closing a minimised Ethereal doesn't work properly
Severity: Unknown
Effect: Error dialogue pops up, but otherwise everything seems to work
       fine.
Steps to Reproduce:
- turn on "Asked for unsaved buffers" option
- capture some packets
- minimise the main window
- right-click the taskbar button and select close
- notice the error box that pops up
Notes:
On 0.10.4 (I only noticed/figured out a couple weeks ago what was
happening) this series of steps would result in an infinite loop in
Ethereal because the Save Buffer dialog would never be displayed, and
I would have to kill Ethereal with the Task Manager. So this is an
improvement.
Error text:
"(ethereal.exe:1384): GLib-GObject-CRITICAL **: file gobject.c: line
1655 (g_object_set_data): assertion `G_IS_OBJECT (object)' failed

(ethereal.exe:1384): GLib-GObject-CRITICAL **: file gobject.c: line
1655 (g_object_set_data): assertion `G_IS_OBJECT (object)' failed"


Asking for the unsaved capture file requires that the main window isn't minimized (GTK2 only). In order to prevent that, I have added a call to present the main window in that case, as this sounds resonable.

Checked it into CVS.

Regards, ULFL